iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gyro:adis16136: fix debugfs_simple_attr.cocci warnings

Browse Source 
Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
for debugfs files.

Semantic patch information:
Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
imposes some significant overhead as compared to
DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().

Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Venkat Prashanth B U 2018-01-07 14:31:57 +05:30 committed by Greg Kroah-Hartman
parent c68c202937
commit 9aaea09b4c
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/iio/gyro/adis16136.c
View File

@ -124,7 +124,7 @@ static int adis16136_show_product_id(void *arg, u64 *val)
return 0; return 0;
} }
DEFINE_SIMPLE_ATTRIBUTE(adis16136_product_id_fops, DEFINE_DEBUGFS_ATTRIBUTE(adis16136_product_id_fops,
adis16136_show_product_id, NULL, "%llu\n"); adis16136_show_product_id, NULL, "%llu\n");
static int adis16136_show_flash_count(void *arg, u64 *val) static int adis16136_show_flash_count(void *arg, u64 *val)
@ -142,18 +142,21 @@ static int adis16136_show_flash_count(void *arg, u64 *val)
return 0; return 0;
} }
DEFINE_SIMPLE_ATTRIBUTE(adis16136_flash_count_fops, DEFINE_DEBUGFS_ATTRIBUTE(adis16136_flash_count_fops,
adis16136_show_flash_count, NULL, "%lld\n"); adis16136_show_flash_count, NULL, "%lld\n");
static int adis16136_debugfs_init(struct iio_dev *indio_dev) static int adis16136_debugfs_init(struct iio_dev *indio_dev)
{ {
struct adis16136 *adis16136 = iio_priv(indio_dev); struct adis16136 *adis16136 = iio_priv(indio_dev);
debugfs_create_file("serial_number", 0400, indio_dev->debugfs_dentry, debugfs_create_file_unsafe("serial_number", 0400,
adis16136, &adis16136_serial_fops); indio_dev->debugfs_dentry, adis16136,
debugfs_create_file("product_id", 0400, indio_dev->debugfs_dentry, &adis16136_serial_fops);
debugfs_create_file_unsafe("product_id", 0400,
indio_dev->debugfs_dentry,
adis16136, &adis16136_product_id_fops); adis16136, &adis16136_product_id_fops);
debugfs_create_file("flash_count", 0400, indio_dev->debugfs_dentry, debugfs_create_file_unsafe("flash_count", 0400,
indio_dev->debugfs_dentry,
adis16136, &adis16136_flash_count_fops); adis16136, &adis16136_flash_count_fops);
return 0; return 0;