iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: hid: Replace WARN_ON() with dev_err()

Browse Source 
WARN_ON() is a bit harsh here, as we just failed to power-off the HID
device while it is getting removed.

Replace it with dev_err().

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Viresh Kumar 2016-02-26 16:44:19 +05:30 committed by Greg Kroah-Hartman
parent b22b7104d5
commit 9b22f155be
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/staging/greybus/hid.c
View File

@ -345,6 +345,7 @@ static int gb_hid_open(struct hid_device *hid)
static void gb_hid_close(struct hid_device *hid)
{
struct gb_hid *ghid = hid->driver_data;
int ret;
/*
* Protecting hid->open to make sure we don't restart data acquistion
@ -355,7 +356,10 @@ static void gb_hid_close(struct hid_device *hid)
clear_bit(GB_HID_STARTED, &ghid->flags);
/* Save some power */
WARN_ON(gb_hid_set_power(ghid, GB_HID_TYPE_PWR_OFF));
ret = gb_hid_set_power(ghid, GB_HID_TYPE_PWR_OFF);
if (ret)
dev_err(&ghid->connection->bundle->dev,
"failed to power off (%d)\n", ret);
}
mutex_unlock(&gb_hid_open_mutex);
}