iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MIPS: Lasat: A couple off by one bugs in picvue_proc.c

Browse Source 
These should be ">=" instead of ">" or we go past the end of the
pvc_lines[] array.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-mips@linux-mips.org
Cc: kernel-janitors@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/6124/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
This commit is contained in:
Dan Carpenter 2013-11-08 12:44:31 +03:00 committed by Ralf Baechle
parent 2b436a3518
commit 9b987c4d74
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
arch/mips/lasat/picvue_proc.c
View File

@ -43,7 +43,7 @@ static int pvc_line_proc_show(struct seq_file *m, void *v)
{ {
int lineno = *(int *)m->private; int lineno = *(int *)m->private;
if (lineno < 0 || lineno > PVC_NLINES) { if (lineno < 0 || lineno >= PVC_NLINES) {
printk(KERN_WARNING "proc_read_line: invalid lineno %d\n", lineno); printk(KERN_WARNING "proc_read_line: invalid lineno %d\n", lineno);
return 0; return 0;
} }
@ -67,7 +67,7 @@ static ssize_t pvc_line_proc_write(struct file *file, const char __user *buf,
char kbuf[PVC_LINELEN]; char kbuf[PVC_LINELEN];
size_t len; size_t len;
BUG_ON(lineno < 0 || lineno > PVC_NLINES); BUG_ON(lineno < 0 || lineno >= PVC_NLINES);
len = min(count, sizeof(kbuf) - 1); len = min(count, sizeof(kbuf) - 1);
if (copy_from_user(kbuf, buf, len)) if (copy_from_user(kbuf, buf, len))