iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use

Browse Source 
We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to
meet kernel coding style guidelines.  This issue was reported by checkpatch.

A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/):

// <smpl>

@@
identifier i;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer z;
@@

- DEFINE_PCI_DEVICE_TABLE(i)
+ const struct pci_device_id i[]
= z;

// </smpl>

[bhelgaas: add semantic patch]
Signed-off-by: Benoit Taine <benoit.taine@lip6.fr>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
This commit is contained in:
Benoit Taine
2014-08-08 15:56:03 +02:00
committed by Bjorn Helgaas
parent c8d6637d04
commit 9baa3c34ac
230 changed files with 242 additions and 240 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/smsc/epic100.c
View File

@ -173,7 +173,7 @@ static const struct epic_chip_info pci_id_tbl[] = {
};
static DEFINE_PCI_DEVICE_TABLE(epic_pci_tbl) = {
static const struct pci_device_id epic_pci_tbl[] = {
{ 0x10B8, 0x0005, 0x1092, 0x0AB4, 0, 0, SMSC_83C170_0 },
{ 0x10B8, 0x0005, PCI_ANY_ID, PCI_ANY_ID, 0, 0, SMSC_83C170 },
{ 0x10B8, 0x0006, PCI_ANY_ID, PCI_ANY_ID,

2
drivers/net/ethernet/smsc/smsc9420.c
View File

@ -83,7 +83,7 @@ struct smsc9420_pdata {
int last_carrier;
};
static DEFINE_PCI_DEVICE_TABLE(smsc9420_id_table) = {
static const struct pci_device_id smsc9420_id_table[] = {
{ PCI_VENDOR_ID_9420, PCI_DEVICE_ID_9420, PCI_ANY_ID, PCI_ANY_ID, },
{ 0, }
};