iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

s390/dasd: Use sysfs_emit() over sprintf()

Browse Source 
sysfs_emit() should be used in show() functions. There are still a
couple of functions that use sprintf().
Replace outstanding occurrences of sprintf() in all show() functions
with sysfs_emit().

Signed-off-by: Jan Höppner <hoeppner@linux.ibm.com>
Reviewed-by: Stefan Haberland <sth@linux.ibm.com>
Signed-off-by: Stefan Haberland <sth@linux.ibm.com>
Link: https://lore.kernel.org/r/20240208164248.540985-3-sth@linux.ibm.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Jan Höppner
2024-02-08 17:42:41 +01:00
committed by Jens Axboe
parent e5de34db1e
commit 9c386d0f6e
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/s390/block/dasd_devmap.c
View File

@@ -1114,7 +1114,7 @@ dasd_use_diag_show(struct device *dev, struct device_attribute *attr, char *buf)
use_diag = (devmap->features & DASD_FEATURE_USEDIAG) != 0; use_diag = (devmap->features & DASD_FEATURE_USEDIAG) != 0;
else else
use_diag = (DASD_FEATURE_DEFAULT & DASD_FEATURE_USEDIAG) != 0; use_diag = (DASD_FEATURE_DEFAULT & DASD_FEATURE_USEDIAG) != 0;
return sprintf(buf, use_diag ? "1\n" : "0\n"); return sysfs_emit(buf, use_diag ? "1\n" : "0\n");
} }
static ssize_t static ssize_t
@@ -1163,7 +1163,7 @@ dasd_use_raw_show(struct device *dev, struct device_attribute *attr, char *buf)
use_raw = (devmap->features & DASD_FEATURE_USERAW) != 0; use_raw = (devmap->features & DASD_FEATURE_USERAW) != 0;
else else
use_raw = (DASD_FEATURE_DEFAULT & DASD_FEATURE_USERAW) != 0; use_raw = (DASD_FEATURE_DEFAULT & DASD_FEATURE_USERAW) != 0;
return sprintf(buf, use_raw ? "1\n" : "0\n"); return sysfs_emit(buf, use_raw ? "1\n" : "0\n");
} }
static ssize_t static ssize_t
@@ -1259,7 +1259,7 @@ dasd_access_show(struct device *dev, struct device_attribute *attr,
if (count < 0) if (count < 0)
return count; return count;
return sprintf(buf, "%d\n", count); return sysfs_emit(buf, "%d\n", count);
} }
static DEVICE_ATTR(host_access_count, 0444, dasd_access_show, NULL); static DEVICE_ATTR(host_access_count, 0444, dasd_access_show, NULL);
@@ -1338,19 +1338,19 @@ static ssize_t dasd_alias_show(struct device *dev,
device = dasd_device_from_cdev(to_ccwdev(dev)); device = dasd_device_from_cdev(to_ccwdev(dev));
if (IS_ERR(device)) if (IS_ERR(device))
return sprintf(buf, "0\n"); return sysfs_emit(buf, "0\n");
if (device->discipline && device->discipline->get_uid && if (device->discipline && device->discipline->get_uid &&
!device->discipline->get_uid(device, &uid)) { !device->discipline->get_uid(device, &uid)) {
if (uid.type == UA_BASE_PAV_ALIAS || if (uid.type == UA_BASE_PAV_ALIAS ||
uid.type == UA_HYPER_PAV_ALIAS) { uid.type == UA_HYPER_PAV_ALIAS) {
dasd_put_device(device); dasd_put_device(device);
return sprintf(buf, "1\n"); return sysfs_emit(buf, "1\n");
} }
} }
dasd_put_device(device); dasd_put_device(device);
return sprintf(buf, "0\n"); return sysfs_emit(buf, "0\n");
} }
static DEVICE_ATTR(alias, 0444, dasd_alias_show, NULL); static DEVICE_ATTR(alias, 0444, dasd_alias_show, NULL);
@@ -1856,7 +1856,7 @@ static ssize_t dasd_pm_show(struct device *dev,
device = dasd_device_from_cdev(to_ccwdev(dev)); device = dasd_device_from_cdev(to_ccwdev(dev));
if (IS_ERR(device)) if (IS_ERR(device))
return sprintf(buf, "0\n"); return sysfs_emit(buf, "0\n");
opm = dasd_path_get_opm(device); opm = dasd_path_get_opm(device);
nppm = dasd_path_get_nppm(device); nppm = dasd_path_get_nppm(device);
@@ -1866,8 +1866,8 @@ static ssize_t dasd_pm_show(struct device *dev,
ifccpm = dasd_path_get_ifccpm(device); ifccpm = dasd_path_get_ifccpm(device);
dasd_put_device(device); dasd_put_device(device);
return sprintf(buf, "%02x %02x %02x %02x %02x %02x\n", opm, nppm, return sysfs_emit(buf, "%02x %02x %02x %02x %02x %02x\n", opm, nppm,
cablepm, cuirpm, hpfpm, ifccpm); cablepm, cuirpm, hpfpm, ifccpm);
} }
static DEVICE_ATTR(path_masks, 0444, dasd_pm_show, NULL); static DEVICE_ATTR(path_masks, 0444, dasd_pm_show, NULL);