iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ceph: convert to noop_direct_IO

Browse Source 
We have our own op, but the WARN_ON is not terribly helpful, and it's
otherwise identical to the noop one. Just use that.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
This commit is contained in:
Jeff Layton 2021-09-23 07:50:08 -04:00 committed by Ilya Dryomov
parent 8bb7eca972
commit 9c43ff4490
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
fs/ceph/addr.c
View File

@ -1306,17 +1306,6 @@ out:
return copied; return copied;
} }
/*
* we set .direct_IO to indicate direct io is supported, but since we
* intercept O_DIRECT reads and writes early, this function should
* never get called.
*/
static ssize_t ceph_direct_io(struct kiocb *iocb, struct iov_iter *iter)
{
WARN_ON(1);
return -EINVAL;
}
const struct address_space_operations ceph_aops = { const struct address_space_operations ceph_aops = {
.readpage = ceph_readpage, .readpage = ceph_readpage,
.readahead = ceph_readahead, .readahead = ceph_readahead,
@ -1327,7 +1316,7 @@ const struct address_space_operations ceph_aops = {
.set_page_dirty = ceph_set_page_dirty, .set_page_dirty = ceph_set_page_dirty,
.invalidatepage = ceph_invalidatepage, .invalidatepage = ceph_invalidatepage,
.releasepage = ceph_releasepage, .releasepage = ceph_releasepage,
.direct_IO = ceph_direct_io, .direct_IO = noop_direct_IO,
}; };
static void ceph_block_sigs(sigset_t *oldset) static void ceph_block_sigs(sigset_t *oldset)