iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net/mlx5: DR, fix a potential use-after-free bug

Browse Source 
[ Upstream commit 6cc64770fb386b10a64a1fe09328396de7bb5262 ]

In line 849 (), "mlx5dr_htbl_put(cur_htbl);" drops the reference to
cur_htbl and may cause cur_htbl to be freed.

However, cur_htbl is subsequently used in the next line, which may result
in an use-after-free bug.

Fix this by calling mlx5dr_err() before the cur_htbl is put.

Signed-off-by: Wentao_Liang <Wentao_Liang_g@163.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Wentao_Liang 2021-08-19 22:30:05 +08:00 committed by Greg Kroah-Hartman
parent 4bbf0a9d90
commit 9c5c65ecbd
1 changed files with 1 additions and 1 deletions

2
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_rule.c

@ -824,9 +824,9 @@ again:
new_htbl = dr_rule_rehash(rule, nic_rule, cur_htbl,
ste_location, send_ste_list);
if (!new_htbl) {
mlx5dr_htbl_put(cur_htbl);
mlx5dr_err(dmn, "Failed creating rehash table, htbl-log_size: %d\n",
cur_htbl->chunk_size);
mlx5dr_htbl_put(cur_htbl);
} else {
cur_htbl = new_htbl;
}