iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HID: hid-sensor-custom: set fixed size for custom attributes

Browse Source 
This is no bugfix (so no Fixes: tag is necessary) as it is
taken care of in hid_sensor_custom_add_attributes().

The motivation for this patch is that:
hid_sensor_custom_field.attr_name and
hid_sensor_custom_field.attrs
has the size of HID_CUSTOM_TOTAL_ATTRS and used in same context.

We compare against HID_CUSTOM_TOTAL_ATTRS when
looping through hid_custom_attrs.

We will silent the smatch error:
hid_sensor_custom_add_attributes() error: buffer overflow
'hid_custom_attrs' 8 <= 10

Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Marcus Folkesson 2022-11-17 13:13:26 +01:00 committed by Jiri Kosina
parent 9861a25fc2
commit 9d013910df
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/hid/hid-sensor-custom.c
View File

@ -62,7 +62,7 @@ struct hid_sensor_sample {
u32 raw_len; u32 raw_len;
} __packed; } __packed;
static struct attribute hid_custom_attrs[] = { static struct attribute hid_custom_attrs[HID_CUSTOM_TOTAL_ATTRS] = {
{.name = "name", .mode = S_IRUGO}, {.name = "name", .mode = S_IRUGO},
{.name = "units", .mode = S_IRUGO}, {.name = "units", .mode = S_IRUGO},
{.name = "unit-expo", .mode = S_IRUGO}, {.name = "unit-expo", .mode = S_IRUGO},