iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

i2c-parport-light: Don't register a platform device resource

Browse Source 
The i2c-parport-light driver isn't a real platform driver, so it
should not instantiate platform devices with resources. The resource
management system can't cope with colliding resources, and we are
likely to create such a colliding resource.

So, better just try to grab the I/O ports we need right at module
initialization time, and bail out if we can't. It has the added
benefit that the module will no longer load if it isn't going to work,
which is definitely more user-friendly.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
This commit is contained in:
Jean Delvare 2008-10-14 17:30:04 +02:00 committed by Jean Delvare
parent 67a37308ae
commit 9def255631
1 changed files with 8 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
drivers/i2c/busses/i2c-parport-light.c
View File

@ -123,11 +123,6 @@ static struct i2c_adapter parport_adapter = {
static int __devinit i2c_parport_probe(struct platform_device *pdev) static int __devinit i2c_parport_probe(struct platform_device *pdev)
{ {
int err; int err;
struct resource *res;
res = platform_get_resource(pdev, IORESOURCE_IO, 0);
if (!request_region(res->start, res->end - res->start + 1, DRVNAME))
return -EBUSY;
/* Reset hardware to a sane state (SCL and SDA high) */ /* Reset hardware to a sane state (SCL and SDA high) */
parport_setsda(NULL, 1); parport_setsda(NULL, 1);
@ -138,29 +133,19 @@ static int __devinit i2c_parport_probe(struct platform_device *pdev)
parport_adapter.dev.parent = &pdev->dev; parport_adapter.dev.parent = &pdev->dev;
err = i2c_bit_add_bus(&parport_adapter); err = i2c_bit_add_bus(&parport_adapter);
if (err) { if (err)
dev_err(&pdev->dev, "Unable to register with I2C\n"); dev_err(&pdev->dev, "Unable to register with I2C\n");
goto exit_region;
}
return 0;
exit_region:
release_region(res->start, res->end - res->start + 1);
return err; return err;
} }
static int __devexit i2c_parport_remove(struct platform_device *pdev) static int __devexit i2c_parport_remove(struct platform_device *pdev)
{ {
struct resource *res;
i2c_del_adapter(&parport_adapter); i2c_del_adapter(&parport_adapter);
/* Un-init if needed (power off...) */ /* Un-init if needed (power off...) */
if (adapter_parm[type].init.val) if (adapter_parm[type].init.val)
line_set(0, &adapter_parm[type].init); line_set(0, &adapter_parm[type].init);
res = platform_get_resource(pdev, IORESOURCE_IO, 0);
release_region(res->start, res->end - res->start + 1);
return 0; return 0;
} }
@ -175,12 +160,6 @@ static struct platform_driver i2c_parport_driver = {
static int __init i2c_parport_device_add(u16 address) static int __init i2c_parport_device_add(u16 address)
{ {
struct resource res = {
.start = address,
.end = address + 2,
.name = DRVNAME,
.flags = IORESOURCE_IO,
};
int err; int err;
pdev = platform_device_alloc(DRVNAME, -1); pdev = platform_device_alloc(DRVNAME, -1);
@ -190,13 +169,6 @@ static int __init i2c_parport_device_add(u16 address)
goto exit; goto exit;
} }
err = platform_device_add_resources(pdev, &res, 1);
if (err) {
printk(KERN_ERR DRVNAME ": Device resource addition failed "
"(%d)\n", err);
goto exit_device_put;
}
err = platform_device_add(pdev); err = platform_device_add(pdev);
if (err) { if (err) {
printk(KERN_ERR DRVNAME ": Device addition failed (%d)\n", printk(KERN_ERR DRVNAME ": Device addition failed (%d)\n",
@ -231,13 +203,16 @@ static int __init i2c_parport_init(void)
base = DEFAULT_BASE; base = DEFAULT_BASE;
} }
if (!request_region(base, 3, DRVNAME))
return -EBUSY;
if (!adapter_parm[type].getscl.val) if (!adapter_parm[type].getscl.val)
parport_algo_data.getscl = NULL; parport_algo_data.getscl = NULL;
/* Sets global pdev as a side effect */ /* Sets global pdev as a side effect */
err = i2c_parport_device_add(base); err = i2c_parport_device_add(base);
if (err) if (err)
goto exit; goto exit_release;
err = platform_driver_register(&i2c_parport_driver); err = platform_driver_register(&i2c_parport_driver);
if (err) if (err)
@ -247,7 +222,8 @@ static int __init i2c_parport_init(void)
exit_device: exit_device:
platform_device_unregister(pdev); platform_device_unregister(pdev);
exit: exit_release:
release_region(base, 3);
return err; return err;
} }
@ -255,6 +231,7 @@ static void __exit i2c_parport_exit(void)
{ {
platform_driver_unregister(&i2c_parport_driver); platform_driver_unregister(&i2c_parport_driver);
platform_device_unregister(pdev); platform_device_unregister(pdev);
release_region(base, 3);
} }
MODULE_AUTHOR("Jean Delvare <khali@linux-fr.org>"); MODULE_AUTHOR("Jean Delvare <khali@linux-fr.org>");