virtio_net: fix possible dim status unrecoverable
When the dim worker is scheduled, if it no longer needs to issue commands, dim may not be able to return to the working state later. For example, the following single queue scenario: 1. The dim worker of rxq0 is scheduled, and the dim status is changed to DIM_APPLY_NEW_PROFILE; 2. dim is disabled or parameters have not been modified; 3. virtnet_rx_dim_work exits directly; Then, even if net_dim is invoked again, it cannot work because the state is not restored to DIM_START_MEASURE. Fixes: 6208799553a8 ("virtio-net: support rx netdim") Signed-off-by: Heng Qi <hengqi@linux.alibaba.com> Reviewed-by: Jiri Pirko <jiri@nvidia.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com> Link: https://lore.kernel.org/r/20240528134116.117426-2-hengqi@linux.alibaba.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
parent
89e281ebff
commit
9e0945b190
@ -4419,9 +4419,9 @@ static void virtnet_rx_dim_work(struct work_struct *work)
|
||||
if (err)
|
||||
pr_debug("%s: Failed to send dim parameters on rxq%d\n",
|
||||
dev->name, qnum);
|
||||
dim->state = DIM_START_MEASURE;
|
||||
}
|
||||
out:
|
||||
dim->state = DIM_START_MEASURE;
|
||||
mutex_unlock(&rq->dim_lock);
|
||||
}
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user