From 9e16bada9299d74fcce1f6b03606a08a2c16da81 Mon Sep 17 00:00:00 2001 From: Luis Felipe Hernandez Date: Tue, 25 Jun 2024 06:55:51 -0400 Subject: [PATCH] hid: bpf: Fix grammar * spelling fix: XBox -> Xbox, lowercase 'b' as per Microsoft branding * rephrase: paddle -> paddles, the controller itself has more than one paddle * rephrase: replace usage of "those" in favor of explicitly making reference to the paddles * grammatical fix: report -> reports, use present tense verb. * spelling fix: interpret * consistency: capitalize the first word in bullet points Signed-off-by: Luis Felipe Hernandez Link: https://patch.msgid.link/20240625105553.50830-1-luis.hernandez093@gmail.com [bentiss: renamed the file into Xbox, not XBox] Signed-off-by: Benjamin Tissoires --- ...lite-2.bpf.c => Microsoft__Xbox-Elite-2.bpf.c} | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) rename drivers/hid/bpf/progs/{Microsoft__XBox-Elite-2.bpf.c => Microsoft__Xbox-Elite-2.bpf.c} (91%) diff --git a/drivers/hid/bpf/progs/Microsoft__XBox-Elite-2.bpf.c b/drivers/hid/bpf/progs/Microsoft__Xbox-Elite-2.bpf.c similarity index 91% rename from drivers/hid/bpf/progs/Microsoft__XBox-Elite-2.bpf.c rename to drivers/hid/bpf/progs/Microsoft__Xbox-Elite-2.bpf.c index 70b16edfb59a..382bba735a2c 100644 --- a/drivers/hid/bpf/progs/Microsoft__XBox-Elite-2.bpf.c +++ b/drivers/hid/bpf/progs/Microsoft__Xbox-Elite-2.bpf.c @@ -15,20 +15,19 @@ HID_BPF_CONFIG( ); /* - * When using the XBox Wireless Controller Elite 2 over Bluetooth, - * the device exports the paddle on the back of the device as a single + * When using the Xbox Wireless Controller Elite 2 over Bluetooth, + * the device exports the paddles on the back of the device as a single * bitfield value of usage "Assign Selection". * - * The kernel doesn't process those usages properly and report KEY_UNKNOWN - * for it. + * The kernel doesn't process the paddles usage properly and reports KEY_UNKNOWN. * - * SDL doesn't know how to interprete that KEY_UNKNOWN and thus ignores the paddles. + * SDL doesn't know how to interpret KEY_UNKNOWN and thus ignores the paddles. * * Given that over USB the kernel uses BTN_TRIGGER_HAPPY[5-8], we - * can tweak the report descriptor to make the kernel interprete it properly: - * - we need an application collection of gamepad (so we have to close the current + * can tweak the report descriptor to make the kernel interpret it properly: + * - We need an application collection of gamepad (so we have to close the current * Consumer Control one) - * - we need to change the usage to be buttons from 0x15 to 0x18 + * - We need to change the usage to be buttons from 0x15 to 0x18 */ #define OFFSET_ASSIGN_SELECTION 211