iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

kfifo: kfifo_copy_{to,from}_user: fix copied bytes calculation

Browse Source 
'copied' and 'len' are in bytes, while 'ret' is in elements, so we need to
multiply 'ret' with the size of one element to get the correct result.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: Stefani Seibold <stefani@seibold.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Lars-Peter Clausen 2013-11-14 14:32:16 -08:00 committed by Linus Torvalds
parent 07968fe4ac
commit a019e48cfb
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/kfifo.c
View File

@ -215,7 +215,7 @@ static unsigned long kfifo_copy_from_user(struct __kfifo *fifo,
* incrementing the fifo->in index counter
*/
smp_wmb();
*copied = len - ret;
*copied = len - ret * esize;
/* return the number of elements which are not copied */
return ret;
}
@ -275,7 +275,7 @@ static unsigned long kfifo_copy_to_user(struct __kfifo *fifo, void __user *to,
* incrementing the fifo->out index counter
*/
smp_wmb();
*copied = len - ret;
*copied = len - ret * esize;
/* return the number of elements which are not copied */
return ret;
}