iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fs/exofs: fix potential memory leak in mount option parsing

Browse Source 
[ Upstream commit 515f1867ad ]

There are some cases can cause memory leak when parsing
option 'osdname'.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Chengguang Xu
2018-06-13 12:05:13 +08:00
committed by Greg Kroah-Hartman
parent bff410ea7e
commit a088fde602
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
fs/exofs/super.c
View File

@ -100,6 +100,7 @@ static int parse_options(char *options, struct exofs_mountopt *opts)
token = match_token(p, tokens, args); token = match_token(p, tokens, args);
switch (token) { switch (token) {
case Opt_name: case Opt_name:
kfree(opts->dev_name);
opts->dev_name = match_strdup(&args[0]); opts->dev_name = match_strdup(&args[0]);
if (unlikely(!opts->dev_name)) { if (unlikely(!opts->dev_name)) {
EXOFS_ERR("Error allocating dev_name"); EXOFS_ERR("Error allocating dev_name");
@ -863,8 +864,10 @@ static struct dentry *exofs_mount(struct file_system_type *type,
int ret; int ret;
ret = parse_options(data, &opts); ret = parse_options(data, &opts);
if (ret) if (ret) {
kfree(opts.dev_name);
return ERR_PTR(ret); return ERR_PTR(ret);
}
if (!opts.dev_name) if (!opts.dev_name)
opts.dev_name = dev_name; opts.dev_name = dev_name;