iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mm/gup_test: fix PIN_LONGTERM_TEST_READ with highmem

Browse Source 
Patch series "selftests/vm: fix some tests on 32bit".

I finally had the time to run some of the selftests written by me
(especially "cow") on x86 PAE.  I found some unexpected "surprises" :)

With these changes, and with [1] on top of mm-unstable, the "cow" tests
and the "ksm_functional_tests" compile and pass as expected (expected
failures with hugetlb in the "cow" tests).  "madv_populate" has one
expected test failure -- x86 does not support softdirty tracking.

#1-#3 fix commits with stable commit ids.  #4 fixes a test that is not in
mm-stable yet.

A note that there are many other compile errors/warnings when compiling on
32bit and with older Linux headers ...  something for another day.

[1] https://lkml.kernel.org/r/20221205150857.167583-1-david@redhat.com


This patch (of 4):

...  we have to kmap()/kunmap(), otherwise this won't work as expected
with highmem.

Link: https://lkml.kernel.org/r/20221205193716.276024-1-david@redhat.com
Link: https://lkml.kernel.org/r/20221205193716.276024-2-david@redhat.com
Fixes: c77369b437f9 ("mm/gup_test: start/stop/read functionality for PIN LONGTERM test")
Signed-off-by: David Hildenbrand <david@redhat.com>
Cc: Shuah Khan <shuah@kernel.org>,
Cc: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
David Hildenbrand 2022-12-05 20:37:13 +01:00 committed by Andrew Morton
parent 6287b7dae8
commit a0ac9b3598
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
mm/gup_test.c
View File

@ -4,6 +4,7 @@
#include <linux/uaccess.h> #include <linux/uaccess.h>
#include <linux/ktime.h> #include <linux/ktime.h>
#include <linux/debugfs.h> #include <linux/debugfs.h>
#include <linux/highmem.h>
#include "gup_test.h" #include "gup_test.h"
static void put_back_pages(unsigned int cmd, struct page **pages, static void put_back_pages(unsigned int cmd, struct page **pages,
@ -297,10 +298,13 @@ static inline int pin_longterm_test_read(unsigned long arg)
return -EFAULT; return -EFAULT;
for (i = 0; i < pin_longterm_test_nr_pages; i++) { for (i = 0; i < pin_longterm_test_nr_pages; i++) {
void *addr = page_to_virt(pin_longterm_test_pages[i]); void *addr = kmap_local_page(pin_longterm_test_pages[i]);
unsigned long ret;
if (copy_to_user((void __user *)(unsigned long)user_addr, addr, ret = copy_to_user((void __user *)(unsigned long)user_addr, addr,
PAGE_SIZE)) PAGE_SIZE);
kunmap_local(addr);
if (ret)
return -EFAULT; return -EFAULT;
user_addr += PAGE_SIZE; user_addr += PAGE_SIZE;
} }