iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

x86: kprobes: fix swapped segment registers in kretprobe

Browse Source 
In commit f007ea26, the order of the %es and %ds segment registers
got accidentally swapped, so synthesized 'struct pt_regs' frames
have the two values inverted.  It's almost sure that these values
never matter, and that they also never differ.  But wrong is wrong.

Signed-off-by: Roland McGrath <roland@redhat.com>
This commit is contained in:
Roland McGrath 2010-07-16 18:17:12 -07:00
parent bea9a6d239
commit a197479848
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/x86/kernel/kprobes.c
View File

@ -640,8 +640,8 @@ static int __kprobes kprobe_handler(struct pt_regs *regs)
/* Skip cs, ip, orig_ax and gs. */ \ /* Skip cs, ip, orig_ax and gs. */ \
" subl $16, %esp\n" \ " subl $16, %esp\n" \
" pushl %fs\n" \ " pushl %fs\n" \
" pushl %ds\n" \
" pushl %es\n" \ " pushl %es\n" \
" pushl %ds\n" \
" pushl %eax\n" \ " pushl %eax\n" \
" pushl %ebp\n" \ " pushl %ebp\n" \
" pushl %edi\n" \ " pushl %edi\n" \