iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dmaengine: Simplify dmaenginem_async_device_register() function

Browse Source 
Use devm_add_action_or_reset() instead of devres_alloc() and
devres_add(), which works the same. This will simplify the
code. There is no functional changes.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230130112830.52353-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Andy Shevchenko 2023-01-30 13:28:30 +02:00 committed by Vinod Koul
parent 40e171c2d3
commit a1beaa50b5
1 changed files with 4 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/dma/dmaengine.c
View File

@ -1322,11 +1322,8 @@ void dma_async_device_unregister(struct dma_device *device)
} }
EXPORT_SYMBOL(dma_async_device_unregister); EXPORT_SYMBOL(dma_async_device_unregister);
static void dmam_device_release(struct device *dev, void *res) static void dmaenginem_async_device_unregister(void *device)
{ {
struct dma_device *device;
device = *(struct dma_device **)res;
dma_async_device_unregister(device); dma_async_device_unregister(device);
} }
@ -1338,22 +1335,13 @@ static void dmam_device_release(struct device *dev, void *res)
*/ */
int dmaenginem_async_device_register(struct dma_device *device) int dmaenginem_async_device_register(struct dma_device *device)
{ {
void *p;
int ret; int ret;
p = devres_alloc(dmam_device_release, sizeof(void *), GFP_KERNEL);
if (!p)
return -ENOMEM;
ret = dma_async_device_register(device); ret = dma_async_device_register(device);
if (!ret) { if (ret)
*(struct dma_device **)p = device;
devres_add(device->dev, p);
} else {
devres_free(p);
}
return ret; return ret;
return devm_add_action(device->dev, dmaenginem_async_device_unregister, device);
} }
EXPORT_SYMBOL(dmaenginem_async_device_register); EXPORT_SYMBOL(dmaenginem_async_device_register);