iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

selftests/bpf: Fix error checking for cpumask_success__load()

Browse Source 
We should verify the return value of cpumask_success__load().

Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20240206081416.26242-4-laoar.shao@gmail.com
This commit is contained in:
Yafang Shao 2024-02-06 16:14:14 +08:00 committed by Andrii Nakryiko
parent abae1ac523
commit a2bff65cfc
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/testing/selftests/bpf/prog_tests/cpumask.c
View File

@ -27,7 +27,7 @@ static void verify_success(const char *prog_name)
struct bpf_program *prog; struct bpf_program *prog;
struct bpf_link *link = NULL; struct bpf_link *link = NULL;
pid_t child_pid; pid_t child_pid;
int status; int status, err;
skel = cpumask_success__open(); skel = cpumask_success__open();
if (!ASSERT_OK_PTR(skel, "cpumask_success__open")) if (!ASSERT_OK_PTR(skel, "cpumask_success__open"))
@ -36,8 +36,8 @@ static void verify_success(const char *prog_name)
skel->bss->pid = getpid(); skel->bss->pid = getpid();
skel->bss->nr_cpus = libbpf_num_possible_cpus(); skel->bss->nr_cpus = libbpf_num_possible_cpus();
cpumask_success__load(skel); err = cpumask_success__load(skel);
if (!ASSERT_OK_PTR(skel, "cpumask_success__load")) if (!ASSERT_OK(err, "cpumask_success__load"))
goto cleanup; goto cleanup;
prog = bpf_object__find_program_by_name(skel->obj, prog_name); prog = bpf_object__find_program_by_name(skel->obj, prog_name);