iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: dpaa: reject unsupported coalescing params

Browse Source 
Set ethtool_ops->supported_coalesce_params to let
the core reject unsupported coalescing parameters.

This driver did not previously reject unsupported parameters
(other than adaptive rx, which will now be rejected by core).

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jakub Kicinski 2020-03-11 15:32:49 -07:00 committed by David S. Miller
parent 8213f6c9a2
commit a3f9dd70bf
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
View File

@ -525,7 +525,6 @@ static int dpaa_get_coalesce(struct net_device *dev,
c->rx_coalesce_usecs = period; c->rx_coalesce_usecs = period;
c->rx_max_coalesced_frames = thresh; c->rx_max_coalesced_frames = thresh;
c->use_adaptive_rx_coalesce = false;
return 0; return 0;
} }
@ -540,9 +539,6 @@ static int dpaa_set_coalesce(struct net_device *dev,
u8 thresh, prev_thresh; u8 thresh, prev_thresh;
int cpu, res; int cpu, res;
if (c->use_adaptive_rx_coalesce)
return -EINVAL;
period = c->rx_coalesce_usecs; period = c->rx_coalesce_usecs;
thresh = c->rx_max_coalesced_frames; thresh = c->rx_max_coalesced_frames;
@ -582,6 +578,8 @@ revert_values:
} }
const struct ethtool_ops dpaa_ethtool_ops = { const struct ethtool_ops dpaa_ethtool_ops = {
.supported_coalesce_params = ETHTOOL_COALESCE_RX_USECS |
ETHTOOL_COALESCE_RX_MAX_FRAMES,
.get_drvinfo = dpaa_get_drvinfo, .get_drvinfo = dpaa_get_drvinfo,
.get_msglevel = dpaa_get_msglevel, .get_msglevel = dpaa_get_msglevel,
.set_msglevel = dpaa_set_msglevel, .set_msglevel = dpaa_set_msglevel,