iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

platform/chrome: wilco_ec: Add newlines to printks

Browse Source 
printk messages all require newlines, or it looks very odd in the log
when messages are not on different lines. Add them.

Cc: Nick Crews <ncrews@chromium.org>
Cc: Daniel Campello <campello@chromium.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
This commit is contained in:
Stephen Boyd 2020-01-21 16:40:32 -08:00 committed by Enric Balletbo i Serra
parent 3b0bfd33ff
commit a532149c99
4 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/platform/chrome/wilco_ec/core.c
View File

@ -94,7 +94,7 @@ static int wilco_ec_probe(struct platform_device *pdev)
ret = wilco_ec_add_sysfs(ec); ret = wilco_ec_add_sysfs(ec);
if (ret < 0) { if (ret < 0) {
dev_err(dev, "Failed to create sysfs entries: %d", ret); dev_err(dev, "Failed to create sysfs entries: %d\n", ret);
goto unregister_rtc; goto unregister_rtc;
} }

8
drivers/platform/chrome/wilco_ec/keyboard_leds.c
View File

@ -69,7 +69,7 @@ static int send_kbbl_msg(struct wilco_ec_device *ec,
ret = wilco_ec_mailbox(ec, &msg); ret = wilco_ec_mailbox(ec, &msg);
if (ret < 0) { if (ret < 0) {
dev_err(ec->dev, dev_err(ec->dev,
"Failed sending keyboard LEDs command: %d", ret); "Failed sending keyboard LEDs command: %d\n", ret);
return ret; return ret;
} }
@ -94,7 +94,7 @@ static int set_kbbl(struct wilco_ec_device *ec, enum led_brightness brightness)
if (response.status) { if (response.status) {
dev_err(ec->dev, dev_err(ec->dev,
"EC reported failure sending keyboard LEDs command: %d", "EC reported failure sending keyboard LEDs command: %d\n",
response.status); response.status);
return -EIO; return -EIO;
} }
@ -147,7 +147,7 @@ static int kbbl_init(struct wilco_ec_device *ec)
if (response.status) { if (response.status) {
dev_err(ec->dev, dev_err(ec->dev,
"EC reported failure sending keyboard LEDs command: %d", "EC reported failure sending keyboard LEDs command: %d\n",
response.status); response.status);
return -EIO; return -EIO;
} }
@ -179,7 +179,7 @@ int wilco_keyboard_leds_init(struct wilco_ec_device *ec)
ret = kbbl_exist(ec, &leds_exist); ret = kbbl_exist(ec, &leds_exist);
if (ret < 0) { if (ret < 0) {
dev_err(ec->dev, dev_err(ec->dev,
"Failed checking keyboard LEDs support: %d", ret); "Failed checking keyboard LEDs support: %d\n", ret);
return ret; return ret;
} }
if (!leds_exist) if (!leds_exist)

4
drivers/platform/chrome/wilco_ec/mailbox.c
View File

@ -163,13 +163,13 @@ static int wilco_ec_transfer(struct wilco_ec_device *ec,
} }
if (rs->data_size != EC_MAILBOX_DATA_SIZE) { if (rs->data_size != EC_MAILBOX_DATA_SIZE) {
dev_dbg(ec->dev, "unexpected packet size (%u != %u)", dev_dbg(ec->dev, "unexpected packet size (%u != %u)\n",
rs->data_size, EC_MAILBOX_DATA_SIZE); rs->data_size, EC_MAILBOX_DATA_SIZE);
return -EMSGSIZE; return -EMSGSIZE;
} }
if (rs->data_size < msg->response_size) { if (rs->data_size < msg->response_size) {
dev_dbg(ec->dev, "EC didn't return enough data (%u < %zu)", dev_dbg(ec->dev, "EC didn't return enough data (%u < %zu)\n",
rs->data_size, msg->response_size); rs->data_size, msg->response_size);
return -EMSGSIZE; return -EMSGSIZE;
} }

6
drivers/platform/chrome/wilco_ec/telemetry.c
View File

@ -367,7 +367,7 @@ static int telem_device_probe(struct platform_device *pdev)
minor = ida_alloc_max(&telem_ida, TELEM_MAX_DEV-1, GFP_KERNEL); minor = ida_alloc_max(&telem_ida, TELEM_MAX_DEV-1, GFP_KERNEL);
if (minor < 0) { if (minor < 0) {
error = minor; error = minor;
dev_err(&pdev->dev, "Failed to find minor number: %d", error); dev_err(&pdev->dev, "Failed to find minor number: %d\n", error);
return error; return error;
} }
@ -427,14 +427,14 @@ static int __init telem_module_init(void)
ret = class_register(&telem_class); ret = class_register(&telem_class);
if (ret) { if (ret) {
pr_err(DRV_NAME ": Failed registering class: %d", ret); pr_err(DRV_NAME ": Failed registering class: %d\n", ret);
return ret; return ret;
} }
/* Request the kernel for device numbers, starting with minor=0 */ /* Request the kernel for device numbers, starting with minor=0 */
ret = alloc_chrdev_region(&dev_num, 0, TELEM_MAX_DEV, TELEM_DEV_NAME); ret = alloc_chrdev_region(&dev_num, 0, TELEM_MAX_DEV, TELEM_DEV_NAME);
if (ret) { if (ret) {
pr_err(DRV_NAME ": Failed allocating dev numbers: %d", ret); pr_err(DRV_NAME ": Failed allocating dev numbers: %d\n", ret);
goto destroy_class; goto destroy_class;
} }
telem_major = MAJOR(dev_num); telem_major = MAJOR(dev_num);