iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net/mlx5: Remove unnecessary spin lock protection

Browse Source 
Taking lag_lock to access ldev->tracker is meaningless in the context of
do_bond() and mlx5_lag_netdev_event().

Signed-off-by: Eli Cohen <elic@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
This commit is contained in:
Eli Cohen
2021-05-03 09:22:43 +03:00
committed by Saeed Mahameed
parent 71513c05a9
commit a546432f2f
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/ethernet/mellanox/mlx5/core/lag.c
View File

@@ -280,9 +280,7 @@ static void mlx5_do_bond(struct mlx5_lag *ldev)
if (!mlx5_lag_is_ready(ldev)) if (!mlx5_lag_is_ready(ldev))
return; return;
spin_lock(&lag_lock);
tracker = ldev->tracker; tracker = ldev->tracker;
spin_unlock(&lag_lock);
do_bond = tracker.is_bonded && mlx5_lag_check_prereq(ldev); do_bond = tracker.is_bonded && mlx5_lag_check_prereq(ldev);
@@ -481,9 +479,7 @@ static int mlx5_lag_netdev_event(struct notifier_block *this,
break; break;
} }
spin_lock(&lag_lock);
ldev->tracker = tracker; ldev->tracker = tracker;
spin_unlock(&lag_lock);
if (changed) if (changed)
mlx5_queue_bond_work(ldev, 0); mlx5_queue_bond_work(ldev, 0);