iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

netfilter: nf_tables: Carry reset boolean in nft_obj_dump_ctx

Browse Source 
Relieve the dump callback from having to inspect nlmsg_type upon each
call, just do it once at start of the dump.

Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
This commit is contained in:
Phil Sutter 2023-10-20 19:34:33 +02:00 committed by Pablo Neira Ayuso
parent 5a893b9cdf
commit a552339063
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
net/netfilter/nf_tables_api.c
View File

@ -7685,6 +7685,7 @@ struct nft_obj_dump_ctx {
unsigned int s_idx; unsigned int s_idx;
char *table; char *table;
u32 type; u32 type;
bool reset;
}; };
static int nf_tables_dump_obj(struct sk_buff *skb, struct netlink_callback *cb) static int nf_tables_dump_obj(struct sk_buff *skb, struct netlink_callback *cb)
@ -7698,12 +7699,8 @@ static int nf_tables_dump_obj(struct sk_buff *skb, struct netlink_callback *cb)
unsigned int entries = 0; unsigned int entries = 0;
struct nft_object *obj; struct nft_object *obj;
unsigned int idx = 0; unsigned int idx = 0;
bool reset = false;
int rc = 0; int rc = 0;
if (NFNL_MSG_TYPE(cb->nlh->nlmsg_type) == NFT_MSG_GETOBJ_RESET)
reset = true;
rcu_read_lock(); rcu_read_lock();
nft_net = nft_pernet(net); nft_net = nft_pernet(net);
cb->seq = READ_ONCE(nft_net->base_seq); cb->seq = READ_ONCE(nft_net->base_seq);
@ -7730,7 +7727,7 @@ static int nf_tables_dump_obj(struct sk_buff *skb, struct netlink_callback *cb)
NFT_MSG_NEWOBJ, NFT_MSG_NEWOBJ,
NLM_F_MULTI | NLM_F_APPEND, NLM_F_MULTI | NLM_F_APPEND,
table->family, table, table->family, table,
obj, reset); obj, ctx->reset);
if (rc < 0) if (rc < 0)
break; break;
@ -7739,7 +7736,7 @@ static int nf_tables_dump_obj(struct sk_buff *skb, struct netlink_callback *cb)
cont: cont:
idx++; idx++;
} }
if (reset && entries) if (ctx->reset && entries)
audit_log_obj_reset(table, nft_net->base_seq, entries); audit_log_obj_reset(table, nft_net->base_seq, entries);
if (rc < 0) if (rc < 0)
break; break;
@ -7766,6 +7763,9 @@ static int nf_tables_dump_obj_start(struct netlink_callback *cb)
if (nla[NFTA_OBJ_TYPE]) if (nla[NFTA_OBJ_TYPE])
ctx->type = ntohl(nla_get_be32(nla[NFTA_OBJ_TYPE])); ctx->type = ntohl(nla_get_be32(nla[NFTA_OBJ_TYPE]));
if (NFNL_MSG_TYPE(cb->nlh->nlmsg_type) == NFT_MSG_GETOBJ_RESET)
ctx->reset = true;
return 0; return 0;
} }