iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

i2c: meson: remove member irq from struct meson_i2c

Browse Source 
Member irq can be replaced with a local variable in probe
because it's nowhere else accessed.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
This commit is contained in:
Heiner Kallweit 2017-03-25 14:01:32 +01:00 committed by Wolfram Sang
parent 8edf52a1e9
commit a55cc70af6
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/i2c/busses/i2c-meson.c
View File

@ -82,7 +82,6 @@ struct meson_i2c {
struct device *dev; struct device *dev;
void __iomem *regs; void __iomem *regs;
struct clk *clk; struct clk *clk;
int irq;
struct i2c_msg *msg; struct i2c_msg *msg;
int state; int state;
@ -391,7 +390,7 @@ static int meson_i2c_probe(struct platform_device *pdev)
struct device_node *np = pdev->dev.of_node; struct device_node *np = pdev->dev.of_node;
struct meson_i2c *i2c; struct meson_i2c *i2c;
struct resource *mem; struct resource *mem;
int ret = 0; int irq, ret = 0;
i2c = devm_kzalloc(&pdev->dev, sizeof(struct meson_i2c), GFP_KERNEL); i2c = devm_kzalloc(&pdev->dev, sizeof(struct meson_i2c), GFP_KERNEL);
if (!i2c) if (!i2c)
@ -418,14 +417,13 @@ static int meson_i2c_probe(struct platform_device *pdev)
if (IS_ERR(i2c->regs)) if (IS_ERR(i2c->regs))
return PTR_ERR(i2c->regs); return PTR_ERR(i2c->regs);
i2c->irq = platform_get_irq(pdev, 0); irq = platform_get_irq(pdev, 0);
if (i2c->irq < 0) { if (irq < 0) {
dev_err(&pdev->dev, "can't find IRQ\n"); dev_err(&pdev->dev, "can't find IRQ\n");
return i2c->irq; return irq;
} }
ret = devm_request_irq(&pdev->dev, i2c->irq, meson_i2c_irq, ret = devm_request_irq(&pdev->dev, irq, meson_i2c_irq, 0, NULL, i2c);
0, dev_name(&pdev->dev), i2c);
if (ret < 0) { if (ret < 0) {
dev_err(&pdev->dev, "can't request IRQ\n"); dev_err(&pdev->dev, "can't request IRQ\n");
return ret; return ret;