iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clk: Silence warnings about lock imbalances

Browse Source 
The recursive spinlock implementation trips up sparse and it
complains that these functions have lock imbalances. That isn't
really true though, so add some __acquires() and __releases()
information so that sparse is quiet.

drivers/clk/clk.c:116:22: warning: context imbalance in 'clk_enable_lock' - wrong count at exit
drivers/clk/clk.c:141:9: warning: context imbalance in 'clk_enable_unlock' - unexpected unlock

Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
This commit is contained in:
Stephen Boyd 2015-07-24 12:24:48 -07:00
parent 661e2180cf
commit a57aa18539
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/clk/clk.c
View File

@ -114,12 +114,14 @@ static void clk_prepare_unlock(void)
} }
static unsigned long clk_enable_lock(void) static unsigned long clk_enable_lock(void)
__acquires(enable_lock)
{ {
unsigned long flags; unsigned long flags;
if (!spin_trylock_irqsave(&enable_lock, flags)) { if (!spin_trylock_irqsave(&enable_lock, flags)) {
if (enable_owner == current) { if (enable_owner == current) {
enable_refcnt++; enable_refcnt++;
__acquire(enable_lock);
return flags; return flags;
} }
spin_lock_irqsave(&enable_lock, flags); spin_lock_irqsave(&enable_lock, flags);
@ -132,12 +134,15 @@ static unsigned long clk_enable_lock(void)
} }
static void clk_enable_unlock(unsigned long flags) static void clk_enable_unlock(unsigned long flags)
__releases(enable_lock)
{ {
WARN_ON_ONCE(enable_owner != current); WARN_ON_ONCE(enable_owner != current);
WARN_ON_ONCE(enable_refcnt == 0); WARN_ON_ONCE(enable_refcnt == 0);
if (--enable_refcnt) if (--enable_refcnt) {
__release(enable_lock);
return; return;
}
enable_owner = NULL; enable_owner = NULL;
spin_unlock_irqrestore(&enable_lock, flags); spin_unlock_irqrestore(&enable_lock, flags);
} }