iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

regulator: s5m8767: Drop regulators OF node reference

Browse Source 
The device node reference obtained with of_get_child_by_name() should be
dropped on error paths.

Fixes: 26aec009f6 ("regulator: add device tree support for s5m8767")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20210121155914.48034-1-krzk@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Krzysztof Kozlowski 2021-01-21 16:59:14 +01:00 committed by Mark Brown
parent e46c52f7ef
commit a5872bd339
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/regulator/s5m8767.c
View File

@ -544,14 +544,18 @@ static int s5m8767_pmic_dt_parse_pdata(struct platform_device *pdev,
rdata = devm_kcalloc(&pdev->dev, rdata = devm_kcalloc(&pdev->dev,
pdata->num_regulators, sizeof(*rdata), pdata->num_regulators, sizeof(*rdata),
GFP_KERNEL); GFP_KERNEL);
if (!rdata) if (!rdata) {
of_node_put(regulators_np);
return -ENOMEM; return -ENOMEM;
}
rmode = devm_kcalloc(&pdev->dev, rmode = devm_kcalloc(&pdev->dev,
pdata->num_regulators, sizeof(*rmode), pdata->num_regulators, sizeof(*rmode),
GFP_KERNEL); GFP_KERNEL);
if (!rmode) if (!rmode) {
of_node_put(regulators_np);
return -ENOMEM; return -ENOMEM;
}
pdata->regulators = rdata; pdata->regulators = rdata;
pdata->opmode = rmode; pdata->opmode = rmode;