iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/tilcdc: use only a single module device table

Browse Source 
The tilcdc driver fails to be built as a module because of extraneous
MODULE_DEVICE_TABLE entries:

drivers/gpu/drm/tilcdc/tilcdc_slave.o:(.data+0x54): multiple definition of `__mod_of_device_table'
drivers/gpu/drm/tilcdc/tilcdc_tfp410.o:(.data+0x54): first defined here
drivers/gpu/drm/tilcdc/tilcdc_panel.o:(.data+0x54): multiple definition of `__mod_of_device_table'
drivers/gpu/drm/tilcdc/tilcdc_tfp410.o:(.data+0x54): first defined here
drivers/gpu/drm/tilcdc/tilcdc_drv.o:(.data+0x184): multiple definition of `__mod_of_device_table'
drivers/gpu/drm/tilcdc/tilcdc_tfp410.o:(.data+0x54): first defined here

Since the entire point of these entries is to make the module autoload
when one of the devices is present, it's enough to keep the one entry
for "ti,am33xx-tilcdc", which should always be there if any of the
others are.

Acked-by: Rob Clark <robdclark@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Dave Airlie <airlied@redhat.com>
This commit is contained in:
Arnd Bergmann 2013-04-23 18:30:43 +02:00 committed by Dave Airlie
parent 84806ade19
commit a59e1ff3b8
3 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/gpu/drm/tilcdc/tilcdc_panel.c
View File

@ -413,7 +413,6 @@ static struct of_device_id panel_of_match[] = {
{ .compatible = "ti,tilcdc,panel", }, { .compatible = "ti,tilcdc,panel", },
{ }, { },
}; };
MODULE_DEVICE_TABLE(of, panel_of_match);
struct platform_driver panel_driver = { struct platform_driver panel_driver = {
.probe = panel_probe, .probe = panel_probe,

1
drivers/gpu/drm/tilcdc/tilcdc_slave.c
View File

@ -353,7 +353,6 @@ static struct of_device_id slave_of_match[] = {
{ .compatible = "ti,tilcdc,slave", }, { .compatible = "ti,tilcdc,slave", },
{ }, { },
}; };
MODULE_DEVICE_TABLE(of, slave_of_match);
struct platform_driver slave_driver = { struct platform_driver slave_driver = {
.probe = slave_probe, .probe = slave_probe,

1
drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
View File

@ -396,7 +396,6 @@ static struct of_device_id tfp410_of_match[] = {
{ .compatible = "ti,tilcdc,tfp410", }, { .compatible = "ti,tilcdc,tfp410", },
{ }, { },
}; };
MODULE_DEVICE_TABLE(of, tfp410_of_match);
struct platform_driver tfp410_driver = { struct platform_driver tfp410_driver = {
.probe = tfp410_probe, .probe = tfp410_probe,