iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

powerpc/powermac: add missing of_node_put

Browse Source 
for_each_node_by_name performs an of_node_get on each
iteration, so a break out of the loop requires an
of_node_put.

This was done using the Coccinelle semantic patch
iterators/for_each_child.cocci

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20230907095521.14053-4-Julia.Lawall@inria.fr
This commit is contained in:
Julia Lawall
2023-09-07 11:55:13 +02:00
committed by Michael Ellerman
parent ce9ecca023
commit a59e9eb252
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
arch/powerpc/platforms/powermac/low_i2c.c
View File

@@ -925,8 +925,10 @@ static void __init smu_i2c_probe(void)
sz = sizeof(struct pmac_i2c_bus) + sizeof(struct smu_i2c_cmd); sz = sizeof(struct pmac_i2c_bus) + sizeof(struct smu_i2c_cmd);
bus = kzalloc(sz, GFP_KERNEL); bus = kzalloc(sz, GFP_KERNEL);
if (bus == NULL) if (bus == NULL) {
of_node_put(busnode);
return; return;
}
bus->controller = controller; bus->controller = controller;
bus->busnode = of_node_get(busnode); bus->busnode = of_node_get(busnode);

4
arch/powerpc/platforms/powermac/smp.c
View File

@@ -598,8 +598,10 @@ static void __init smp_core99_setup_i2c_hwsync(int ncpus)
name = "Pulsar"; name = "Pulsar";
break; break;
} }
if (pmac_tb_freeze != NULL) if (pmac_tb_freeze != NULL) {
of_node_put(cc);
break; break;
}
} }
if (pmac_tb_freeze != NULL) { if (pmac_tb_freeze != NULL) {
/* Open i2c bus for synchronous access */ /* Open i2c bus for synchronous access */