iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Input: msg2638 - only read linux,keycodes array if necessary

Browse Source 
The linux,keycodes property is optional.
Fix the driver not probing when it's not specified.

Fixes: c18ef50346f2 ("Input: msg2638 - add support for msg2138 key events")
Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
Link: https://lore.kernel.org/r/20221130210202.2069213-1-vincent.knecht@mailoo.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
Vincent Knecht 2022-11-30 15:15:25 -08:00 committed by Dmitry Torokhov
parent b2b80d9dd1
commit a5df8025f3
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/input/touchscreen/msg2638.c
View File

@ -412,13 +412,15 @@ static int msg2638_ts_probe(struct i2c_client *client)
msg2638->num_keycodes = ARRAY_SIZE(msg2638->keycodes);
}
error = device_property_read_u32_array(dev, "linux,keycodes",
msg2638->keycodes,
msg2638->num_keycodes);
if (error) {
dev_err(dev, "Unable to read linux,keycodes values: %d\n",
error);
return error;
if (msg2638->num_keycodes > 0) {
error = device_property_read_u32_array(dev, "linux,keycodes",
msg2638->keycodes,
msg2638->num_keycodes);
if (error) {
dev_err(dev, "Unable to read linux,keycodes values: %d\n",
error);
return error;
}
}
error = devm_request_threaded_irq(dev, client->irq,