iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HID: explain out-of-range check better

Browse Source 
Extend the comment explaining the condition for discarding
out-of-range values to clarify the cases in which devices don't
provide any logical min/max.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Jiri Kosina 2013-06-19 23:52:11 +02:00
parent 6f1891d019
commit a688393bd3
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/hid/hid-input.c
View File

@ -1042,7 +1042,11 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct
/* /*
* Ignore out-of-range values as per HID specification, * Ignore out-of-range values as per HID specification,
* section 5.10 and 6.2.25 * section 5.10 and 6.2.25.
*
* The logical_minimum < logical_maximum check is done so that we
* don't unintentionally discard values sent by devices which
* don't specify logical min and max.
*/ */
if ((field->flags & HID_MAIN_ITEM_VARIABLE) && if ((field->flags & HID_MAIN_ITEM_VARIABLE) &&
(field->logical_minimum < field->logical_maximum) && (field->logical_minimum < field->logical_maximum) &&