iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

platform/x86/amd/pmf: Fix memory leak in amd_pmf_get_pb_data()

Browse Source 
amd_pmf_get_pb_data() will allocate memory for the policy buffer,
but does not free it if copy_from_user() fails. This leads to a memory
leak.

Fixes: 10817f28e5 ("platform/x86/amd/pmf: Add capability to sideload of policy binary")
Reviewed-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Signed-off-by: Cong Liu <liucong2@kylinos.cn>
Link: https://lore.kernel.org/r/20240124012939.6550-1-liucong2@kylinos.cn
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
This commit is contained in:
Cong Liu 2024-01-24 09:29:38 +08:00 committed by Hans de Goede
parent cedecdba60
commit a692a86efe
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/platform/x86/amd/pmf/tee-if.c
View File

@ -298,8 +298,10 @@ static ssize_t amd_pmf_get_pb_data(struct file *filp, const char __user *buf,
if (!new_policy_buf) if (!new_policy_buf)
return -ENOMEM; return -ENOMEM;
if (copy_from_user(new_policy_buf, buf, length)) if (copy_from_user(new_policy_buf, buf, length)) {
kfree(new_policy_buf);
return -EFAULT; return -EFAULT;
}
kfree(dev->policy_buf); kfree(dev->policy_buf);
dev->policy_buf = new_policy_buf; dev->policy_buf = new_policy_buf;