iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/modes: Switch to named mode descriptors

Browse Source 
The current named mode parsing relies only on the mode name, and doesn't
allow to specify any other parameter.

Let's convert that string list to an array of a custom structure that will
hold the name and some additional parameters in the future.

Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
Tested-by: Mateusz Kwiatkowski <kfyatek+publicgit@gmail.com>
Link: https://lore.kernel.org/r/20220728-rpi-analog-tv-properties-v9-10-24b168e5bcd5@cerno.tech
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
This commit is contained in:
Maxime Ripard 2022-11-14 14:00:29 +01:00
parent a631bf30eb
commit a7ab155397
No known key found for this signature in database
GPG Key ID: E3EF0D6F671851C5
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/gpu/drm/drm_modes.c
View File

@ -1750,9 +1750,13 @@ static int drm_mode_parse_cmdline_options(const char *str,
return 0; return 0;
} }
static const char * const drm_named_modes_whitelist[] = { struct drm_named_mode {
"NTSC", const char *name;
"PAL", };
static const struct drm_named_mode drm_named_modes[] = {
{ "NTSC", },
{ "PAL", },
}; };
static int drm_mode_parse_cmdline_named_mode(const char *name, static int drm_mode_parse_cmdline_named_mode(const char *name,
@ -1784,14 +1788,15 @@ static int drm_mode_parse_cmdline_named_mode(const char *name,
* We're sure we're a named mode at this point, iterate over the * We're sure we're a named mode at this point, iterate over the
* list of modes we're aware of. * list of modes we're aware of.
*/ */
for (i = 0; i < ARRAY_SIZE(drm_named_modes_whitelist); i++) { for (i = 0; i < ARRAY_SIZE(drm_named_modes); i++) {
const struct drm_named_mode *mode = &drm_named_modes[i];
int ret; int ret;
ret = str_has_prefix(name, drm_named_modes_whitelist[i]); ret = str_has_prefix(name, mode->name);
if (ret != name_end) if (ret != name_end)
continue; continue;
strcpy(cmdline_mode->name, drm_named_modes_whitelist[i]); strcpy(cmdline_mode->name, mode->name);
cmdline_mode->specified = true; cmdline_mode->specified = true;
return 1; return 1;