iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Staging: bcm: Fix three initialization errors in InterfaceDld.c

Browse Source 
This patch fixes three initialization errors.
One is an incorrect initialization of a static
variable. The other two are incorrect
initializations in an if statement. These
errors were found by checkpatch.pl.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Kevin McKinney 2011-10-20 08:15:23 -04:00 committed by Greg Kroah-Hartman
parent a5e4b81e27
commit a86581829f
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/staging/bcm/InterfaceDld.c
View File

@ -59,7 +59,7 @@ int InterfaceFileReadbackFromChip(PVOID arg, struct file *flp, unsigned int on_c
mm_segment_t oldfs = {0}; mm_segment_t oldfs = {0};
int errno = 0, len = 0, is_config_file = 0; int errno = 0, len = 0, is_config_file = 0;
loff_t pos = 0; loff_t pos = 0;
static int fw_down = 0; static int fw_down;
INT Status = STATUS_SUCCESS; INT Status = STATUS_SUCCESS;
PS_INTERFACE_ADAPTER psIntfAdapter = (PS_INTERFACE_ADAPTER)arg; PS_INTERFACE_ADAPTER psIntfAdapter = (PS_INTERFACE_ADAPTER)arg;
@ -136,9 +136,9 @@ static int bcm_download_config_file(PMINI_ADAPTER Adapter, FIRMWARE_INFO *psFwIn
B_UINT32 value = 0; B_UINT32 value = 0;
if (Adapter->pstargetparams == NULL) { if (Adapter->pstargetparams == NULL) {
if ((Adapter->pstargetparams = kmalloc(sizeof(STARGETPARAMS), GFP_KERNEL)) == NULL) { Adapter->pstargetparams = kmalloc(sizeof(STARGETPARAMS), GFP_KERNEL);
if (Adapter->pstargetparams == NULL)
return -ENOMEM; return -ENOMEM;
}
} }
if (psFwInfo->u32FirmwareLength != sizeof(STARGETPARAMS)) if (psFwInfo->u32FirmwareLength != sizeof(STARGETPARAMS))
@ -317,7 +317,8 @@ static INT buffRdbkVerify(PMINI_ADAPTER Adapter, PUCHAR mappedbuffer, UINT u32Fi
break; break;
} }
if (STATUS_SUCCESS != (retval = bcm_compare_buff_contents(readbackbuff, mappedbuffer, len))) retval = bcm_compare_buff_contents(readbackbuff, mappedbuffer, len);
if (STATUS_SUCCESS != retval)
break; break;
u32StartingAddress += len; u32StartingAddress += len;