iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/i915/fbc: Split plane stride checks per-platform

Browse Source 
Carve up stride_is_valid() into per-platform variants to
make it easier to see what limits are actually being imposed.

TODO: maybe go for vfuncs later

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231003194256.28569-2-ville.syrjala@linux.intel.com
This commit is contained in:
Ville Syrjälä 2023-10-03 22:42:52 +03:00
parent da7b3b03f4
commit a8a3b4cd74
1 changed files with 51 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
drivers/gpu/drm/i915/display/intel_fbc.c
View File

@ -853,6 +853,47 @@ void intel_fbc_cleanup(struct drm_i915_private *i915)
}
}
static bool i8xx_fbc_stride_is_valid(const struct intel_plane_state *plane_state)
{
const struct drm_framebuffer *fb = plane_state->hw.fb;
unsigned int stride = intel_fbc_plane_stride(plane_state) *
fb->format->cpp[0];
return stride == 4096 || stride == 8192;
}
static bool i965_fbc_stride_is_valid(const struct intel_plane_state *plane_state)
{
const struct drm_framebuffer *fb = plane_state->hw.fb;
unsigned int stride = intel_fbc_plane_stride(plane_state) *
fb->format->cpp[0];
return stride >= 2048 && stride <= 16384;
}
static bool g4x_fbc_stride_is_valid(const struct intel_plane_state *plane_state)
{
return true;
}
static bool skl_fbc_stride_is_valid(const struct intel_plane_state *plane_state)
{
const struct drm_framebuffer *fb = plane_state->hw.fb;
unsigned int stride = intel_fbc_plane_stride(plane_state) *
fb->format->cpp[0];
/* Display WA #1105: skl,bxt,kbl,cfl,glk */
if (fb->modifier == DRM_FORMAT_MOD_LINEAR && stride & 511)
return false;
return true;
}
static bool icl_fbc_stride_is_valid(const struct intel_plane_state *plane_state)
{
return true;
}
static bool stride_is_valid(const struct intel_plane_state *plane_state)
{
struct drm_i915_private *i915 = to_i915(plane_state->uapi.plane->dev);
@ -864,23 +905,16 @@ static bool stride_is_valid(const struct intel_plane_state *plane_state)
if (drm_WARN_ON_ONCE(&i915->drm, (stride & (64 - 1)) != 0))
return false;
/* Below are the additional FBC restrictions. */
if (stride < 512)
return false;
if (DISPLAY_VER(i915) == 2 || DISPLAY_VER(i915) == 3)
return stride == 4096 || stride == 8192;
if (DISPLAY_VER(i915) == 4 && !IS_G4X(i915) &&
(stride < 2048 || stride > 16384))
return false;
/* Display WA #1105: skl,bxt,kbl,cfl,glk */
if ((DISPLAY_VER(i915) == 9 || IS_GEMINILAKE(i915)) &&
fb->modifier == DRM_FORMAT_MOD_LINEAR && stride & 511)
return false;
return true;
if (DISPLAY_VER(i915) >= 11)
return icl_fbc_stride_is_valid(plane_state);
else if (DISPLAY_VER(i915) >= 9)
return skl_fbc_stride_is_valid(plane_state);
else if (DISPLAY_VER(i915) >= 5 || IS_G4X(i915))
return g4x_fbc_stride_is_valid(plane_state);
else if (DISPLAY_VER(i915) == 4)
return i965_fbc_stride_is_valid(plane_state);
else
return i8xx_fbc_stride_is_valid(plane_state);
}
static bool pixel_format_is_valid(const struct intel_plane_state *plane_state)