iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: qedf: use correct strncpy() size

Browse Source 
gcc-8 warns during link-time optimization that the strncpy() call passes
the size of the source buffer rather than the destination:

drivers/scsi/qedf/qedf_dbg.c: In function 'qedf_uevent_emit':
include/linux/string.h:253: error: 'strncpy' specified bound depends on the length of the source argument [-Werror=stringop-overflow=]

This changes it to strscpy() with the correct length, guaranteeing a
properly nul-terminated string of the right size.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Chad Dupuis <chad.dupuis@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Arnd Bergmann
2018-02-02 14:12:20 +01:00
committed by Martin K. Petersen
parent d9ea463a1c
commit a8db6140d7
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/scsi/qedf/qedf_dbg.c
View File

@ -160,7 +160,7 @@ qedf_uevent_emit(struct Scsi_Host *shost, u32 code, char *msg)
switch (code) { switch (code) {
case QEDF_UEVENT_CODE_GRCDUMP: case QEDF_UEVENT_CODE_GRCDUMP:
if (msg) if (msg)
strncpy(event_string, msg, strlen(msg)); strscpy(event_string, msg, sizeof(event_string));
else else
sprintf(event_string, "GRCDUMP=%u", shost->host_no); sprintf(event_string, "GRCDUMP=%u", shost->host_no);
break; break;