iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

selftests/resctrl: Use remount_resctrlfs() consistently with boolean

Browse Source 
remount_resctrlfs() accepts a boolean value as an argument. Some tests
pass 0/1 and some tests pass true/false.

Make all the callers of remount_resctrlfs() use true/false so that the
parameter usage is consistent across tests.

Co-developed-by: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
This commit is contained in:
Ilpo Järvinen
2023-02-15 15:06:04 +02:00
committed by Shuah Khan
parent e48c32306b
commit a967e17f91
5 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tools/testing/selftests/resctrl/cat_test.c
View File

@ -145,7 +145,7 @@ int cat_perf_miss_val(int cpu_no, int n, char *cache_type)
struct resctrl_val_param param = { struct resctrl_val_param param = {
.resctrl_val = CAT_STR, .resctrl_val = CAT_STR,
.cpu_no = cpu_no, .cpu_no = cpu_no,
.mum_resctrlfs = 0, .mum_resctrlfs = false,
.setup = cat_setup, .setup = cat_setup,
}; };

7
tools/testing/selftests/resctrl/cmt_test.c
View File

@ -82,12 +82,11 @@ void cmt_test_cleanup(void)
int cmt_resctrl_val(int cpu_no, int n, char **benchmark_cmd) int cmt_resctrl_val(int cpu_no, int n, char **benchmark_cmd)
{ {
int ret, mum_resctrlfs; int ret;
cache_size = 0; cache_size = 0;
mum_resctrlfs = 1;
ret = remount_resctrlfs(mum_resctrlfs); ret = remount_resctrlfs(true);
if (ret) if (ret)
return ret; return ret;
@ -118,7 +117,7 @@ int cmt_resctrl_val(int cpu_no, int n, char **benchmark_cmd)
.ctrlgrp = "c1", .ctrlgrp = "c1",
.mongrp = "m1", .mongrp = "m1",
.cpu_no = cpu_no, .cpu_no = cpu_no,
.mum_resctrlfs = 0, .mum_resctrlfs = false,
.filename = RESULT_FILE_NAME, .filename = RESULT_FILE_NAME,
.mask = ~(long_mask << n) & long_mask, .mask = ~(long_mask << n) & long_mask,
.span = cache_size * n / count_of_bits, .span = cache_size * n / count_of_bits,

2
tools/testing/selftests/resctrl/mba_test.c
View File

@ -154,7 +154,7 @@ int mba_schemata_change(int cpu_no, char *bw_report, char **benchmark_cmd)
.ctrlgrp = "c1", .ctrlgrp = "c1",
.mongrp = "m1", .mongrp = "m1",
.cpu_no = cpu_no, .cpu_no = cpu_no,
.mum_resctrlfs = 1, .mum_resctrlfs = true,
.filename = RESULT_FILE_NAME, .filename = RESULT_FILE_NAME,
.bw_report = bw_report, .bw_report = bw_report,
.setup = mba_setup .setup = mba_setup

2
tools/testing/selftests/resctrl/mbm_test.c
View File

@ -122,7 +122,7 @@ int mbm_bw_change(int span, int cpu_no, char *bw_report, char **benchmark_cmd)
.mongrp = "m1", .mongrp = "m1",
.span = span, .span = span,
.cpu_no = cpu_no, .cpu_no = cpu_no,
.mum_resctrlfs = 1, .mum_resctrlfs = true,
.filename = RESULT_FILE_NAME, .filename = RESULT_FILE_NAME,
.bw_report = bw_report, .bw_report = bw_report,
.setup = mbm_setup .setup = mbm_setup

2
tools/testing/selftests/resctrl/resctrl.h
View File

@ -64,7 +64,7 @@ struct resctrl_val_param {
char mongrp[64]; char mongrp[64];
int cpu_no; int cpu_no;
unsigned long span; unsigned long span;
int mum_resctrlfs; bool mum_resctrlfs;
char filename[64]; char filename[64];
char *bw_report; char *bw_report;
unsigned long mask; unsigned long mask;