iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

crypto: amlogic - ensure error variable err is set before returning it

Browse Source 
Currently when the call to crypto_engine_alloc_init fails the error
return path returns an uninitialized value in the variable err. Fix
this by setting err to -ENOMEM.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Corentin Labbe <clabbe@baylibre.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Colin Ian King 2019-10-29 11:32:30 +00:00 committed by Herbert Xu
parent d832a61285
commit a970429366
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/crypto/amlogic/amlogic-gxl-core.c
View File

@ -162,6 +162,7 @@ static int meson_allocate_chanlist(struct meson_dev *mc)
if (!mc->chanlist[i].engine) { if (!mc->chanlist[i].engine) {
dev_err(mc->dev, "Cannot allocate engine\n"); dev_err(mc->dev, "Cannot allocate engine\n");
i--; i--;
err = -ENOMEM;
goto error_engine; goto error_engine;
} }
err = crypto_engine_start(mc->chanlist[i].engine); err = crypto_engine_start(mc->chanlist[i].engine);