iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: target: alua: Remove in_interrupt() usage in core_alua_check_nonop_delay()

Browse Source 
core_alua_check_nonop_delay() uses in_interrupt() to decide if it is safe
to sleep.

The usage of in_interrupt() in drivers is phased out and Linus clearly
requested that code which changes behaviour depending on context should
either be separated or the context be conveyed in an argument passed by the
caller, which usually knows the context.

core_alua_check_nonop_delay() has two callers:

 - target_submit_cmd_map_sgls()
   Kernel doc says it that it must be called from process context. Also has
   a BUG_ON(in_interrupt()).

 - iscsit_setup_scsi_cmd()
   Invokes iscsit_add_reject_cmd() which does GFP_KERNEL allocation and
   target_cmd_init_cdb() which may do GFP_KERNEL allocations.

Remove the in_interrupt() check because all callers are from preemptible
context.

Link: https://lore.kernel.org/r/20201220203638.43615-5-bigeasy@linutronix.de
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Sebastian Andrzej Siewior 2020-12-20 21:36:36 +01:00 committed by Martin K. Petersen
parent f88a10f80d
commit a97451ac1e
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/target/target_core_alua.c
View File

@ -860,8 +860,6 @@ int core_alua_check_nonop_delay(
{ {
if (!(cmd->se_cmd_flags & SCF_ALUA_NON_OPTIMIZED)) if (!(cmd->se_cmd_flags & SCF_ALUA_NON_OPTIMIZED))
return 0; return 0;
if (in_interrupt())
return 0;
/* /*
* The ALUA Active/NonOptimized access state delay can be disabled * The ALUA Active/NonOptimized access state delay can be disabled
* in via configfs with a value of zero * in via configfs with a value of zero