iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: rcar-vin: Fix a reference count leak.

Browse Source 
pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus call pm_runtime_put_noidle()
if pm_runtime_get_sync() fails.

Fixes: 90dedce9bc54 ("media: rcar-vin: add function to manipulate Gen3 chsel value")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Qiushi Wu 2020-06-14 00:30:08 +02:00 committed by Mauro Carvalho Chehab
parent 98fae901c8
commit aaffa0126a
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/platform/rcar-vin/rcar-dma.c
View File

@ -1420,8 +1420,10 @@ int rvin_set_channel_routing(struct rvin_dev *vin, u8 chsel)
int ret; int ret;
ret = pm_runtime_get_sync(vin->dev); ret = pm_runtime_get_sync(vin->dev);
if (ret < 0) if (ret < 0) {
pm_runtime_put_noidle(vin->dev);
return ret; return ret;
}
/* Make register writes take effect immediately. */ /* Make register writes take effect immediately. */
vnmc = rvin_read(vin, VNMC_REG); vnmc = rvin_read(vin, VNMC_REG);