iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: unisys: refactor find_dev()

Browse Source 
Fix the function definition so that it is a single line. Fix CamelCase
parameter names:

busNo => bus_no
devNo => dev_no

Get rid of the goto and just break out of the for loop, since that does
the exact same thing.

Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Benjamin Romer 2014-12-05 17:09:02 -05:00 committed by Greg Kroah-Hartman
parent 2b6040c51f
commit ab12d8a00a
1 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/staging/unisys/uislib/uislib.c
View File

@ -1187,31 +1187,29 @@ static ssize_t info_debugfs_read(struct file *file, char __user *buf,
debug_buf, total_bytes);
}
static struct device_info *
find_dev(u32 busNo, u32 devNo)
static struct device_info *find_dev(u32 bus_no, u32 dev_no)
{
struct bus_info *bus;
struct device_info *dev = NULL;
read_lock(&bus_list_lock);
for (bus = bus_list; bus; bus = bus->next) {
if (bus->bus_no == busNo) {
if (bus->bus_no == bus_no) {
/* make sure the device number is valid */
if (devNo >= bus->device_count) {
LOGERR("%s bad busNo, devNo=%d,%d",
if (dev_no >= bus->device_count) {
LOGERR("%s bad bus_no, dev_no=%d,%d",
__func__,
(int)(busNo), (int)(devNo));
goto Away;
(int)bus_no, (int)dev_no);
break;
}
dev = bus->device[devNo];
dev = bus->device[dev_no];
if (!dev)
LOGERR("%s bad busNo, devNo=%d,%d",
LOGERR("%s bad bus_no, dev_no=%d,%d",
__func__,
(int)(busNo), (int)(devNo));
goto Away;
(int)bus_no, (int)dev_no);
break;
}
}
Away:
read_unlock(&bus_list_lock);
return dev;
}