iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: connection: fix duplicating naming in _gb_hd_connection_insert()

Browse Source 
Though this doesn't cause any logical issues as far as the behavior of the
routine is concerned as the local variable would be considered inside the
'while' loop.

But its better not to use the same name for variables at different levels.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
This commit is contained in:
Viresh Kumar 2014-11-14 17:25:04 +05:30 committed by Greg Kroah-Hartman
parent 1dd90df403
commit ab34291da5
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/staging/greybus/connection.c
View File

@ -23,13 +23,13 @@ static void _gb_hd_connection_insert(struct greybus_host_device *hd,
u16 cport_id = connection->hd_cport_id;
while (*link) {
struct gb_connection *connection;
struct gb_connection *_connection;
above = *link;
connection = rb_entry(above, struct gb_connection, hd_node);
if (connection->hd_cport_id > cport_id)
_connection = rb_entry(above, struct gb_connection, hd_node);
if (_connection->hd_cport_id > cport_id)
link = &above->rb_left;
else if (connection->hd_cport_id < cport_id)
else if (_connection->hd_cport_id < cport_id)
link = &above->rb_right;
}
rb_link_node(node, above, link);