iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

KVM: x86 emulator: 0f (20|21|22|23) ignore mod bits.

Browse Source 
Resent spec says that for 0f (20|21|22|23) the 2 bits in the mod field
are ignored. Interestingly enough older spec says that 11 is only valid
encoding.

Signed-off-by: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
This commit is contained in:
Gleb Natapov 2010-03-18 15:20:09 +02:00 committed by Avi Kivity
parent 6e1e5ffee8
commit ab8557b2b3
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
arch/x86/kvm/emulate.c
View File

@ -2520,28 +2520,20 @@ twobyte_insn:
c->dst.type = OP_NONE; c->dst.type = OP_NONE;
break; break;
case 0x20: /* mov cr, reg */ case 0x20: /* mov cr, reg */
if (c->modrm_mod != 3)
goto cannot_emulate;
c->regs[c->modrm_rm] = ops->get_cr(c->modrm_reg, ctxt->vcpu); c->regs[c->modrm_rm] = ops->get_cr(c->modrm_reg, ctxt->vcpu);
c->dst.type = OP_NONE; /* no writeback */ c->dst.type = OP_NONE; /* no writeback */
break; break;
case 0x21: /* mov from dr to reg */ case 0x21: /* mov from dr to reg */
if (c->modrm_mod != 3)
goto cannot_emulate;
if (emulator_get_dr(ctxt, c->modrm_reg, &c->regs[c->modrm_rm])) if (emulator_get_dr(ctxt, c->modrm_reg, &c->regs[c->modrm_rm]))
goto cannot_emulate; goto cannot_emulate;
rc = X86EMUL_CONTINUE; rc = X86EMUL_CONTINUE;
c->dst.type = OP_NONE; /* no writeback */ c->dst.type = OP_NONE; /* no writeback */
break; break;
case 0x22: /* mov reg, cr */ case 0x22: /* mov reg, cr */
if (c->modrm_mod != 3)
goto cannot_emulate;
ops->set_cr(c->modrm_reg, c->modrm_val, ctxt->vcpu); ops->set_cr(c->modrm_reg, c->modrm_val, ctxt->vcpu);
c->dst.type = OP_NONE; c->dst.type = OP_NONE;
break; break;
case 0x23: /* mov from reg to dr */ case 0x23: /* mov from reg to dr */
if (c->modrm_mod != 3)
goto cannot_emulate;
if (emulator_set_dr(ctxt, c->modrm_reg, c->regs[c->modrm_rm])) if (emulator_set_dr(ctxt, c->modrm_reg, c->regs[c->modrm_rm]))
goto cannot_emulate; goto cannot_emulate;
rc = X86EMUL_CONTINUE; rc = X86EMUL_CONTINUE;