iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

xfs: fallback to vmalloc for large buffers in xfs_attrmulti_attr_get

Browse Source 
xfsdump uses for a large buffer for extended attributes, which has a
kmalloc'd shadow buffer in the kernel. This can fail after the
system has been running for some time as it is a high order
allocation. Add a fallback to vmalloc so that it doesn't require
contiguous memory and so won't randomly fail while xfsdump is
running.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
This commit is contained in:
Dave Chinner 2012-03-07 04:50:21 +00:00 committed by Ben Myers
parent 6eb2466036
commit ad650f5b27
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
fs/xfs/xfs_ioctl.c
View File

@ -450,9 +450,12 @@ xfs_attrmulti_attr_get(
if (*len > XATTR_SIZE_MAX) if (*len > XATTR_SIZE_MAX)
return EINVAL; return EINVAL;
kbuf = kmalloc(*len, GFP_KERNEL); kbuf = kmem_zalloc(*len, KM_SLEEP | KM_MAYFAIL);
if (!kbuf) if (!kbuf) {
return ENOMEM; kbuf = kmem_zalloc_large(*len);
if (!kbuf)
return ENOMEM;
}
error = xfs_attr_get(XFS_I(inode), name, kbuf, (int *)len, flags); error = xfs_attr_get(XFS_I(inode), name, kbuf, (int *)len, flags);
if (error) if (error)
@ -462,7 +465,10 @@ xfs_attrmulti_attr_get(
error = EFAULT; error = EFAULT;
out_kfree: out_kfree:
kfree(kbuf); if (is_vmalloc_addr(kbuf))
kmem_free_large(kbuf);
else
kmem_free(kbuf);
return error; return error;
} }