iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

serial: sh-sci: simplify locking when re-issuing RXDMA fails

Browse Source 
Avoid a superfluous unlock/lock-pair by simply moving the printout to
the end of bailing out.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240506114016.30498-10-wsa+renesas@sang-engineering.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wolfram Sang 2024-05-06 13:40:20 +02:00 committed by Greg Kroah-Hartman
parent 0c9c1ea583
commit ae1b6b4c0a
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/tty/serial/sh-sci.c
View File

@ -1360,14 +1360,12 @@ static void sci_dma_rx_complete(void *arg)
return; return;
fail: fail:
uart_port_unlock_irqrestore(port, flags);
dev_warn(port->dev, "Failed submitting Rx DMA descriptor\n");
/* Switch to PIO */ /* Switch to PIO */
uart_port_lock_irqsave(port, &flags);
dmaengine_terminate_async(chan); dmaengine_terminate_async(chan);
sci_dma_rx_chan_invalidate(s); sci_dma_rx_chan_invalidate(s);
sci_dma_rx_reenable_irq(s); sci_dma_rx_reenable_irq(s);
uart_port_unlock_irqrestore(port, flags); uart_port_unlock_irqrestore(port, flags);
dev_warn(port->dev, "Failed submitting Rx DMA descriptor\n");
} }
static void sci_dma_tx_release(struct sci_port *s) static void sci_dma_tx_release(struct sci_port *s)