iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

spi: Clean up probe and remove functions

Browse Source 
While backporting 33cf00e5 ("spi: attach/detach SPI device to the ACPI
power domain"), I noticed that the code changes were suboptimal:

* Why use &spi->dev when we have dev at hand?

* After fixing the above, spi is used only once, so we don't really
  need a local variable for it.

This results in the following clean-up.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
This commit is contained in:
Jean Delvare 2014-02-13 15:28:41 +01:00 committed by Mark Brown
parent 38dbfb59d1
commit aec35f4ee6
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/spi/spi.c
View File

@ -255,13 +255,12 @@ EXPORT_SYMBOL_GPL(spi_bus_type);
static int spi_drv_probe(struct device *dev) static int spi_drv_probe(struct device *dev)
{ {
const struct spi_driver *sdrv = to_spi_driver(dev->driver); const struct spi_driver *sdrv = to_spi_driver(dev->driver);
struct spi_device *spi = to_spi_device(dev);
int ret; int ret;
acpi_dev_pm_attach(&spi->dev, true); acpi_dev_pm_attach(dev, true);
ret = sdrv->probe(spi); ret = sdrv->probe(to_spi_device(dev));
if (ret) if (ret)
acpi_dev_pm_detach(&spi->dev, true); acpi_dev_pm_detach(dev, true);
return ret; return ret;
} }
@ -269,11 +268,10 @@ static int spi_drv_probe(struct device *dev)
static int spi_drv_remove(struct device *dev) static int spi_drv_remove(struct device *dev)
{ {
const struct spi_driver *sdrv = to_spi_driver(dev->driver); const struct spi_driver *sdrv = to_spi_driver(dev->driver);
struct spi_device *spi = to_spi_device(dev);
int ret; int ret;
ret = sdrv->remove(spi); ret = sdrv->remove(to_spi_device(dev));
acpi_dev_pm_detach(&spi->dev, true); acpi_dev_pm_detach(dev, true);
return ret; return ret;
} }