iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: pcs: lynx: no need to read LPA in lynx_pcs_get_state_2500basex()

Browse Source 
Nothing useful is done with the LPA variable in lynx_pcs_get_state_2500basex(),
we can just remove the read.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20240513115345.2452799-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Vladimir Oltean 2024-05-13 14:53:45 +03:00 committed by Jakub Kicinski
parent d20e391c76
commit afd29f36aa
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/pcs/pcs-lynx.c
View File

@ -61,11 +61,10 @@ static void lynx_pcs_get_state_usxgmii(struct mdio_device *pcs,
static void lynx_pcs_get_state_2500basex(struct mdio_device *pcs, static void lynx_pcs_get_state_2500basex(struct mdio_device *pcs,
struct phylink_link_state *state) struct phylink_link_state *state)
{ {
int bmsr, lpa; int bmsr;
bmsr = mdiodev_read(pcs, MII_BMSR); bmsr = mdiodev_read(pcs, MII_BMSR);
lpa = mdiodev_read(pcs, MII_LPA); if (bmsr < 0) {
if (bmsr < 0 || lpa < 0) {
state->link = false; state->link = false;
return; return;
} }