From b030c45844cfe0d4c89202cd6c9f4697b3a25a6a Mon Sep 17 00:00:00 2001 From: Eric Biggers Date: Fri, 27 Oct 2023 12:52:06 -0700 Subject: [PATCH] crypto: testmgr - move pkcs1pad(rsa,sha3-*) to correct place alg_test_descs[] needs to be in sorted order, since it is used for binary search. This fixes the following boot-time warning: testmgr: alg_test_descs entries in wrong order: 'pkcs1pad(rsa,sha512)' before 'pkcs1pad(rsa,sha3-256)' Fixes: ee62afb9d02d ("crypto: rsa-pkcs1pad - Add FIPS 202 SHA-3 support") Signed-off-by: Eric Biggers Reviewed-by: Dimitri John Ledkov Signed-off-by: Herbert Xu --- crypto/testmgr.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/crypto/testmgr.c b/crypto/testmgr.c index 1dc93bf608d4..15c7a3011269 100644 --- a/crypto/testmgr.c +++ b/crypto/testmgr.c @@ -5456,14 +5456,6 @@ static const struct alg_test_desc alg_test_descs[] = { .suite = { .akcipher = __VECS(pkcs1pad_rsa_tv_template) } - }, { - .alg = "pkcs1pad(rsa,sha384)", - .test = alg_test_null, - .fips_allowed = 1, - }, { - .alg = "pkcs1pad(rsa,sha512)", - .test = alg_test_null, - .fips_allowed = 1, }, { .alg = "pkcs1pad(rsa,sha3-256)", .test = alg_test_null, @@ -5476,6 +5468,14 @@ static const struct alg_test_desc alg_test_descs[] = { .alg = "pkcs1pad(rsa,sha3-512)", .test = alg_test_null, .fips_allowed = 1, + }, { + .alg = "pkcs1pad(rsa,sha384)", + .test = alg_test_null, + .fips_allowed = 1, + }, { + .alg = "pkcs1pad(rsa,sha512)", + .test = alg_test_null, + .fips_allowed = 1, }, { .alg = "poly1305", .test = alg_test_hash,