iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "drm/sched: Define pr_fmt() for DRM using pr_*()"

Browse Source 
From Jani:
The drm_print.[ch] facilities use very few pr_*() calls directly. The
users of pr_*() calls do not necessarily include <drm/drm_print.h> at
all, and really don't have to.

Even the ones that do include it, usually have <linux/...> includes
first, and <drm/...> includes next. Notably, <linux/kernel.h> includes
<linux/printk.h>.

And, of course, <linux/printk.h> defines pr_fmt() itself if not already
defined.

No, it's encouraged not to use pr_*() at all, and prefer drm device
based logging, or device based logging.

This reverts commit 36245bd02e88e68ac5955c2958c968879d7b75a9.

Signed-off-by: Luben Tuikov <ltuikov89@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/878r75wzm9.fsf@intel.com
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Jani Nikula <jani.nikula@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231111024130.11464-2-ltuikov89@gmail.com
This commit is contained in:
Luben Tuikov 2023-11-10 20:01:57 -05:00
parent 50c1a36f59
commit b0e396d68f
1 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
include/drm/drm_print.h
View File

@ -26,20 +26,6 @@
#ifndef DRM_PRINT_H_
#define DRM_PRINT_H_
/* Define this before including linux/printk.h, so that the format
* string in pr_*() macros is correctly set for DRM. If a file wants
* to define this to something else, it should do so before including
* this header file.
*
* It is encouraged code using pr_err() to prefix their format with
* the string "*ERROR* ", to make it easier to scan kernel logs. For
* instance,
* pr_err("*ERROR* <the rest of your format string here>", args).
*/
#ifndef pr_fmt
#define pr_fmt(fmt) "[drm] " fmt
#endif
#include <linux/compiler.h>
#include <linux/printk.h>
#include <linux/seq_file.h>