iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

kdb: drop newline in unknown command output

Browse Source 
When an unknown command is entered, kdb prints "Unknown kdb command:"
and then the unknown text, including the newline character. This
causes the ending single-quote mark to be printed on the next line
by itself, so just change the ending newline character to a null
character (end of string) so that it won't be "printed."

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Jason Wessel <jason.wessel@windriver.com>
Cc: kgdb-bugreport@lists.sourceforge.net
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
This commit is contained in:
Randy Dunlap 2017-12-08 10:19:23 -08:00 committed by Jason Wessel
parent 1e0ce03bf1
commit b0f73bc7f1
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
kernel/debug/kdb/kdb_main.c
View File

@ -1150,6 +1150,16 @@ void kdb_set_current_task(struct task_struct *p)
kdb_current_regs = NULL; kdb_current_regs = NULL;
} }
static void drop_newline(char *buf)
{
size_t len = strlen(buf);
if (len == 0)
return;
if (*(buf + len - 1) == '\n')
*(buf + len - 1) = '\0';
}
/* /*
* kdb_local - The main code for kdb. This routine is invoked on a * kdb_local - The main code for kdb. This routine is invoked on a
* specific processor, it is not global. The main kdb() routine * specific processor, it is not global. The main kdb() routine
@ -1327,6 +1337,7 @@ do_full_getstr:
cmdptr = cmd_head; cmdptr = cmd_head;
diag = kdb_parse(cmdbuf); diag = kdb_parse(cmdbuf);
if (diag == KDB_NOTFOUND) { if (diag == KDB_NOTFOUND) {
drop_newline(cmdbuf);
kdb_printf("Unknown kdb command: '%s'\n", cmdbuf); kdb_printf("Unknown kdb command: '%s'\n", cmdbuf);
diag = 0; diag = 0;
} }