iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gpio: xgene: mark PM functions as __maybe_unused

Browse Source 
When CONFIG_PM_SLEEP is disabled, we get a warning about unused functions:

drivers/gpio/gpio-xgene.c:155:12: warning: 'xgene_gpio_resume' defined but not used [-Wunused-function]
 static int xgene_gpio_resume(struct device *dev)
            ^~~~~~~~~~~~~~~~~
drivers/gpio/gpio-xgene.c:142:12: warning: 'xgene_gpio_suspend' defined but not used [-Wunused-function]
 static int xgene_gpio_suspend(struct device *dev)

The warnings are harmless and can be avoided by simplifying the code and marking
the functions as __maybe_unused.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Arnd Bergmann 2017-02-17 16:13:44 +01:00 committed by Linus Walleij
parent fa6256db03
commit b115bebc07
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/gpio/gpio-xgene.c
View File

@ -42,9 +42,7 @@ struct xgene_gpio {
struct gpio_chip chip; struct gpio_chip chip;
void __iomem *base; void __iomem *base;
spinlock_t lock; spinlock_t lock;
#ifdef CONFIG_PM
u32 set_dr_val[XGENE_MAX_GPIO_BANKS]; u32 set_dr_val[XGENE_MAX_GPIO_BANKS];
#endif
}; };
static int xgene_gpio_get(struct gpio_chip *gc, unsigned int offset) static int xgene_gpio_get(struct gpio_chip *gc, unsigned int offset)
@ -138,8 +136,7 @@ static int xgene_gpio_dir_out(struct gpio_chip *gc,
return 0; return 0;
} }
#ifdef CONFIG_PM static __maybe_unused int xgene_gpio_suspend(struct device *dev)
static int xgene_gpio_suspend(struct device *dev)
{ {
struct xgene_gpio *gpio = dev_get_drvdata(dev); struct xgene_gpio *gpio = dev_get_drvdata(dev);
unsigned long bank_offset; unsigned long bank_offset;
@ -152,7 +149,7 @@ static int xgene_gpio_suspend(struct device *dev)
return 0; return 0;
} }
static int xgene_gpio_resume(struct device *dev) static __maybe_unused int xgene_gpio_resume(struct device *dev)
{ {
struct xgene_gpio *gpio = dev_get_drvdata(dev); struct xgene_gpio *gpio = dev_get_drvdata(dev);
unsigned long bank_offset; unsigned long bank_offset;
@ -166,10 +163,6 @@ static int xgene_gpio_resume(struct device *dev)
} }
static SIMPLE_DEV_PM_OPS(xgene_gpio_pm, xgene_gpio_suspend, xgene_gpio_resume); static SIMPLE_DEV_PM_OPS(xgene_gpio_pm, xgene_gpio_suspend, xgene_gpio_resume);
#define XGENE_GPIO_PM_OPS (&xgene_gpio_pm)
#else
#define XGENE_GPIO_PM_OPS NULL
#endif
static int xgene_gpio_probe(struct platform_device *pdev) static int xgene_gpio_probe(struct platform_device *pdev)
{ {
@ -241,7 +234,7 @@ static struct platform_driver xgene_gpio_driver = {
.name = "xgene-gpio", .name = "xgene-gpio",
.of_match_table = xgene_gpio_of_match, .of_match_table = xgene_gpio_of_match,
.acpi_match_table = ACPI_PTR(xgene_gpio_acpi_match), .acpi_match_table = ACPI_PTR(xgene_gpio_acpi_match),
.pm = XGENE_GPIO_PM_OPS, .pm = &xgene_gpio_pm,
}, },
.probe = xgene_gpio_probe, .probe = xgene_gpio_probe,
}; };