iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gpio: pca953x: avoid logically dead code

Browse Source 
The current code logic make the condition "else if (reg >= 0x54)"
can't be true, cause the dead code. So fix it to match the coder
expectation. This is reported by Coverity.

Fixes: 13c5d4ce8060 ("gpio: pca953x: Add support for PCAL6534")
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
This commit is contained in:
Haibo Chen 2022-12-11 00:05:59 +02:00 committed by Bartosz Golaszewski
parent 29f5c6e69f
commit b1453d1eb9
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/gpio/gpio-pca953x.c
View File

@ -309,17 +309,7 @@ static bool pcal6534_check_register(struct pca953x_chip *chip, unsigned int reg,
int bank; int bank;
int offset; int offset;
if (reg >= 0x30) { if (reg >= 0x54) {
/*
* Reserved block between 14h and 2Fh does not align on
* expected bank boundaries like other devices.
*/
int temp = reg - 0x30;
bank = temp / NBANK(chip);
offset = temp - (bank * NBANK(chip));
bank += 8;
} else if (reg >= 0x54) {
/* /*
* Handle lack of reserved registers after output port * Handle lack of reserved registers after output port
* configuration register to form a bank. * configuration register to form a bank.
@ -329,6 +319,16 @@ static bool pcal6534_check_register(struct pca953x_chip *chip, unsigned int reg,
bank = temp / NBANK(chip); bank = temp / NBANK(chip);
offset = temp - (bank * NBANK(chip)); offset = temp - (bank * NBANK(chip));
bank += 16; bank += 16;
} else if (reg >= 0x30) {
/*
* Reserved block between 14h and 2Fh does not align on
* expected bank boundaries like other devices.
*/
int temp = reg - 0x30;
bank = temp / NBANK(chip);
offset = temp - (bank * NBANK(chip));
bank += 8;
} else { } else {
bank = reg / NBANK(chip); bank = reg / NBANK(chip);
offset = reg - (bank * NBANK(chip)); offset = reg - (bank * NBANK(chip));