iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

can: mcp251x: mcp251x_can_probe(): add missing unregister_candev() in error path

Browse Source 
In mcp251x_can_probe(), if mcp251x_gpio_setup() fails, it forgets to
unregister the CAN device.

Fix this by unregistering can device in mcp251x_can_probe().

Fixes: 2d52dabbef60 ("can: mcp251x: add GPIO support")
Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
Link: https://lore.kernel.org/all/20221024090256.717236-1-dzm91@hust.edu.cn
[mkl: adjust label]
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
This commit is contained in:
Dongliang Mu 2022-10-24 17:02:52 +08:00 committed by Marc Kleine-Budde
parent 3e5b341882
commit b1a09b6368
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/can/spi/mcp251x.c
View File

@ -1415,11 +1415,14 @@ static int mcp251x_can_probe(struct spi_device *spi)
ret = mcp251x_gpio_setup(priv); ret = mcp251x_gpio_setup(priv);
if (ret) if (ret)
goto error_probe; goto out_unregister_candev;
netdev_info(net, "MCP%x successfully initialized.\n", priv->model); netdev_info(net, "MCP%x successfully initialized.\n", priv->model);
return 0; return 0;
out_unregister_candev:
unregister_candev(net);
error_probe: error_probe:
destroy_workqueue(priv->wq); destroy_workqueue(priv->wq);
priv->wq = NULL; priv->wq = NULL;